deprecation(semver): deprecate Comparator.semver property

[timreichen]

• deprecates Comparator.semver property in favour of Comparatorextending SemVer.

[iuioiua]

What is the reasoning behind this?

[timreichen]

What is the reasoning behind this?

Imo separating Operator and SemVer by individual properties is just unnecessary nesting.

[iuioiua]

I'm not sure about this change. It'd require many changes to the std/semver API, and its benefits aren't apparent.

[timreichen]

I'm not sure about this change. It'd require many changes to the std/semver API, and its benefits aren't apparent.

I think it declutters the interface. It also will simplify SemVerRange, and once we redefine SemVerRange without the ranges property, it will look much more clean:

before:

const range = { ranges: [ [ { operator: "<", semver: { major: 1, minor: 2, patch: 3 } } ] ] }

after

const range = [ [ { operator: "<", major: 1, minor: 2, patch: 3 } ] ]

But we can wait with this until we decide about #4047 and discuss this some more.

[iuioiua]

But we can wait with this until we decide about #4047 and discuss this some more.

Yeah, I think we should do that.

[kt3k]

I think we should first decide on what to do about #4047 before changing anything about Comparator

[timreichen]

I think we should first decide on what to do about #4047 before changing anything about Comparator

This is about the type Comparator which will stay public either way because it is part of SemVerRange.

[kt3k]

This is about the type Comparator which will stay public either way because it is part of SemVerRange.

I think we can stop using Comparator in SemVerRange definition if we only want to change SemVerRange

[timreichen]

This is about the type Comparator which will stay public either way because it is part of SemVerRange.

I think we can stop using Comparator in SemVerRange definition if we only want to change SemVerRange

How do you mean exactly?

[kt3k]

For example, by replacing Comparator in SemVerRangeAnd like the below:

type SemVerRangeAnd = (SemVer & { operator: Operator })[];

[iuioiua]

Does this PR still apply if Comparator is now deprecated?

[timreichen]

Does this PR still apply if Comparator is now deprecated?

I will push another PR where we can do that step when renaming SemVerRange to Range directly. Closing.