Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use performance.now in benching module #253

Closed
wants to merge 1 commit into from
Closed

Use performance.now in benching module #253

wants to merge 1 commit into from

Conversation

dsseng
Copy link
Contributor

@dsseng dsseng commented Mar 8, 2019

Use performance.now instead of Date.now for faster measurements.

@ry
Copy link
Member

ry commented Mar 8, 2019

@chiefbiiko are you ok with this?

@hayd
Copy link
Contributor

hayd commented Mar 10, 2019

This should wait til denoland/deno#1777. There may be some further tweaks possible after that anyway.

@zekth
Copy link
Contributor

zekth commented Mar 10, 2019

Agreed. Sorry for the late push but have to fix my builds issue.

@zekth
Copy link
Contributor

zekth commented Apr 15, 2019

@sh7dm because denoland/deno#1977 has been merged you can rebase the PR and it can be merged to deno_std

@hayd
Copy link
Contributor

hayd commented May 10, 2019

Bump!

@zekth zekth mentioned this pull request May 10, 2019
Merged
ry
ry approved these changes May 10, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry
Copy link
Member

ry commented May 10, 2019

This has merge conflicts - please resolve.

@ry
Copy link
Member

ry commented May 10, 2019

landed in #385

@ry ry closed this May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dsseng @ry @hayd @zekth