-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement collections/sortBy ( closes #1061 ) #1069
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LionC
changed the title
Implement collections/sortBy
Implement collections/sortBy ( solves #1061 )
Jul 27, 2021
LionC
changed the title
Implement collections/sortBy ( solves #1061 )
Implement collections/sortBy
Jul 27, 2021
LionC
changed the title
Implement collections/sortBy
Implement collections/sortBy ( closes #1061 )
Jul 27, 2021
kt3k
reviewed
Jul 28, 2021
kt3k
reviewed
Jul 28, 2021
kt3k
reviewed
Jul 28, 2021
The test cases look good to me. |
kt3k
approved these changes
Aug 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LionC LGTM. Nice work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
sortBy
function to thecollections
module.sortBy
allows you to sort an array without mutating it by an arbitrary selected value like this:sortBy
was part of the original proposal (see #1065 and its links) and in the discussions following the merge of the initial set of functions, seemed to have consensus, which is why I went forward and implemented it.Notes on the implementation: I chose to limit the selector function to common sortable types. I looked into different options and they all seemed hacky or inconvenient for users of the function. The approach in the PR seemed like the best compromise between not caring about return types at all (and thus not saving people from hard to track bugs) and specifying every possible case.
This closes #1061