fix(ini): correctly handle quoted values in parse() (#5592)

denoland · Aug 2, 2024 · 69a579e · 69a579e
1 parent 3f13395
commit 69a579e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/ini/_ini_map.ts b/ini/_ini_map.ts
@@ -42,6 +42,13 @@ export type ReviverFunction = (
 
 const ASSIGNMENT_MARK = "=";
 
+function trimQuotes(value: string): string {
+  if (value.startsWith('"') && value.endsWith('"')) {
+    return value.slice(1, -1);
+  }
+  return value;
+}
+
 /**
  * Class implementation for fine control of INI data structures.
  */
@@ -345,7 +352,7 @@ export class IniMap {
         }
 
         const key = leftHand.trim();
-        const value = rightHand.trim();
+        const value = trimQuotes(rightHand.trim());
 
         if (currentSection) {
           const lineValue: LineValue = {

diff --git a/ini/parse_test.ts b/ini/parse_test.ts
@@ -37,6 +37,7 @@ Deno.test({
       reviver: (_, value) => Number(value),
     });
     assertValidParse(`a=b\n[section]\nc=d`, { a: "b", section: { c: "d" } });
+    assertValidParse('value="value"', { value: "value" });
     assertValidParse("#comment\nkeyA=1977-05-25\n[section1]\nkeyA=100", {
       keyA: "1977-05-25",
       section1: { keyA: "100" },