test(cli): improve Spinner test (#5108)

denoland · Jun 24, 2024 · 3fac8a2 · 3fac8a2
1 parent e276271
commit 3fac8a2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/cli/spinner_test.ts b/cli/spinner_test.ts
@@ -4,6 +4,7 @@ import {
   assertEquals,
   assertGreater,
   assertLess,
+  assertLessOrEqual,
   assertStringIncludes,
 } from "@std/assert";
 import { delay } from "@std/async/delay";
@@ -183,10 +184,9 @@ Deno.test("Spinner.start() begins the sequence", async () => {
 
 Deno.test("Spinner.stop() terminates the sequence", async () => {
   const text = await spawnDeno(["cli/testdata/spinner_cases/stop.ts"]);
-  assertEquals(
-    text,
-    `${LINE_CLEAR}⠋${COLOR_RESET} ${LINE_CLEAR}⠙${COLOR_RESET} `,
-  );
+  // Spinner renders 2 times and then renders LINE_CLEAR at the end.
+  // (LINE_CLEAR(4) + ⠋(1) COLOR_RESET(4) + SPACE(1)) * 2 + LINE_CLEAR(4) = 24
+  assertLessOrEqual(text.length, 24);
 });
 
 Deno.test("Spinner.message can be updated", async () => {

diff --git a/cli/testdata/spinner_cases/stop.ts b/cli/testdata/spinner_cases/stop.ts
@@ -4,4 +4,5 @@ const spinner = new Spinner();
 
 spinner.start();
 
-setTimeout(spinner.stop, 200);
+setTimeout(() => spinner.stop(), 200);
+setTimeout(() => {}, 500);