Fix flaky tests caused by relaxed load in C++ 'shared_ptr::use_count()' #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piscisaureus
added a commit
to piscisaureus/safe_v8
that referenced
this pull request
Aug 31, 2020
* The `Default` trait did not actually get derived for `SharedPtr<T>`. This is solved by implementing `Default` manually. * Trait function `Shared::get()` used to return a mutable raw pointer (`*mut Self`), but it would be inconceivable to ever mutate the referenced value. It was changed to return a const pointer instead. * Added some basic unit tests for types `SharedPtr` and `SharedRef`.
piscisaureus
added a commit
to piscisaureus/safe_v8
that referenced
this pull request
Aug 31, 2020
piscisaureus
changed the title
shared_ptr::use_count() relaxed load
piscisaureus
changed the title
shared_ptr::use_count() relaxed load
piscisaureus
added a commit
to piscisaureus/safe_v8
that referenced
this pull request
Aug 31, 2020
piscisaureus
added a commit
to piscisaureus/safe_v8
that referenced
this pull request
Aug 31, 2020
piscisaureus
changed the title
ry
reviewed
Aug 31, 2020
ry
reviewed
Aug 31, 2020
ry
reviewed
Aug 31, 2020
|
Are we even using shared_ptr in a multithreaded way? I don't really understand what is happening here. |
ry
approved these changes
Aug 31, 2020
Theoretically the thread could be preempted, or a page fault could happen, in between dropping the My alternative theory is that this is what SPECTRE mitigation looks like. @bnoordhuis I wonder if you have any theories... |
* The `Default` trait did not actually get derived for `SharedPtr<T>`. This is solved by implementing `Default` manually. * Trait function `Shared::get()` used to return a mutable raw pointer (`*mut Self`), but it would be inconceivable to ever mutate the referenced value. It was changed to return a const pointer instead. * Added some basic unit tests for types `SharedPtr` and `SharedRef`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.