feat: eszip v2 #40
Merged
feat: eszip v2 #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
littledivy
reviewed
Jan 6, 2022
lucacasonato
force-pushed
the
v2_first_pass
branch
from
b3f9704
to
e1418e1
Compare
Co-authored-by: Divy Srivastava <[email protected]>
lucacasonato
force-pushed
the
v2_first_pass
branch
from
e1418e1
to
1471097
Compare
bartlomieju
reviewed
Jan 20, 2022
littledivy
reviewed
Jan 20, 2022
littledivy
reviewed
Jan 25, 2022
bartlomieju
reviewed
Jan 26, 2022
bartlomieju
approved these changes
Jan 26, 2022
littledivy
reviewed
Jan 27, 2022
| } | ||
| let start = read; | ||
| read += $n; | ||
| &header_bytes[start..read] |
There was a problem hiding this comment.
Since this is a macro, it could created a fixed array and copy &header_bytes[start..read] into it. This will eliminate the .try_into().unwrap() calls below
There was a problem hiding this comment.
Can't do, because read! is invoked with a non const length, for example read!(specifier_len, "specifier"). The length of an array needs to be const.
littledivy
reviewed
Jan 27, 2022
| source_map: EszipV2SourceSlot, | ||
| }, | ||
| Redirect { | ||
| target: String, |
There was a problem hiding this comment.
Consider using Cow<'a, str> instead?
There was a problem hiding this comment.
This would require that the EszipV2Module structs have a lifetime. I don't think that can be achieved easily.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a first pass a new iteration of the ESZip format. This PR also changes the
purpose of this crate: it is now exclusively responsible for three things:
Eszipstruct that can contain either a V1, or V2 eszip, but exposes a unified module loading API.deno_graph::ModuleGraphinto a V2 eszipThe crate is not anymore responsible for module loading itself, and does not anymore contain a module loader.