-
Notifications
You must be signed in to change notification settings - Fork 625
feat: virtual database entries for npm and github #659
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks @pi0 and sorry for the delay.
My only concern about this is that I'm not sure I want to support this yet forever. I've labeled it as an experimental feature - let's see how it goes.
Thanks, @ry for helping to merge. I agree it may not be the best URL pattern for the long term. |
nice! Question (possibly mistyped):
shouldn't it be: btw, what is the reason to resolve to the root of the repo? |
@srdjan Yes could be simpler but I think it also adds some implications in cost of omitting PS: Updated PR description for |
Just for reference seems this solution is deprecated |
The first time I came to the deno.land website I was quite surprised not to be able to resolve my repo.
For the listing, of course, it makes sense to make a PR to
database.json
but with this addition, any project can still have an elegant URL while keeping the website scalable.New working URLs:
Preview: