Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Wasm modules #543

Merged
merged 17 commits into from
Nov 18, 2024
Merged

feat: Wasm modules #543

merged 17 commits into from
Nov 18, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Oct 31, 2024 •
edited
Loading

  • Tests
    • Imports tests
  • Integrate in CLI before merging

@dsherret dsherret changed the title feat: wasm modules feat: Wasm modules Oct 31, 2024
@dsherret dsherret mentioned this pull request Oct 31, 2024
Merged
@dsherret dsherret mentioned this pull request Oct 31, 2024
Merged
@dsherret dsherret marked this pull request as ready for review November 15, 2024 22:39
@dsherret dsherret requested a review from bartlomieju November 15, 2024 22:58
bartlomieju
bartlomieju approved these changes Nov 16, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/graph.rs Show resolved Hide resolved
@dsherret dsherret merged commit 167c234 into denoland:main Nov 18, 2024
16 checks passed
@dsherret dsherret deleted the wasm_imports_2 branch November 18, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsherret @bartlomieju