Default to camelCase for object wrap ops #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`fn from_point` in Rust is exposed as `.fromPoint` in JS. I think this is better than having an explict rename attribute since that's very rare to be used.
bartlomieju
reviewed
Nov 18, 2024
bartlomieju
approved these changes
Nov 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #966 +/- ##
==========================================
+ Coverage 81.43% 81.53% +0.10%
==========================================
Files 97 98 +1
Lines 23877 25367 +1490
==========================================
+ Hits 19445 20684 +1239
- Misses 4432 4683 +251 ☔ View full report in Codecov by Sentry. |
littledivy
added a commit
to denoland/deno
that referenced
this pull request
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fn from_pointin Rust is exposed as.fromPointin JS. I think this is better than having an explict rename attribute since that's very rare to be used.