Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use sys_traits for reading from import map #151

Merged

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Jan 9, 2025

It's easier for someone to provide a sys implementation than having to provide a closure.

Copy link
Member

@nathanwhit nathanwhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit 5f3139c into denoland:main Jan 14, 2025
3 checks passed
@dsherret dsherret deleted the refactor_use_sys_traits_for_reading_import_map branch January 14, 2025 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants