feat: make the cache manifest more deterministic#53
Merged
dsherret merged 1 commit intodenoland:mainfrom Jul 19, 2024
Merged
Conversation
29 tasks
|
|
Member
|
This is released in 0.10.2 in case you want to open a PR in the CLI repo bumping it. Otherwise I'll get to it soon. |
Contributor
Author
|
I opened a PR in the deno CLI repo that bumps the dependency. |
dsherret
pushed a commit
to denoland/deno
that referenced
this pull request
Jul 21, 2024
This PR will bump the deno_cache_dir dependency from 0.10.0 to 0.10.2. This will make the cache manifest at manifest.json more deterministic (see denoland/deno_cache_dir#53 ) <!-- Before submitting a PR, please read https://docs.deno.com/runtime/manual/references/contributing 1. Give the PR a descriptive title. Examples of good title: - fix(std/http): Fix race condition in server - docs(console): Update docstrings - feat(doc): Handle nested reexports Examples of bad title: - fix #7123 - update docs - fix bugs 2. Ensure there is a related issue and it is referenced in the PR text. 3. Ensure there are tests that cover the changes. 4. Ensure `cargo test` passes. 5. Ensure `./tools/format.js` passes without changing files. 6. Ensure `./tools/lint.js` passes. 7. Open as a draft PR if your work is still in progress. The CI won't run all steps, but you can add '[ci]' to a commit message to force it to. 8. If you would like to run the benchmarks on the CI, add the 'ci-bench' label. -->
bartlomieju
pushed a commit
to denoland/deno
that referenced
this pull request
Jul 22, 2024
This PR will bump the deno_cache_dir dependency from 0.10.0 to 0.10.2. This will make the cache manifest at manifest.json more deterministic (see denoland/deno_cache_dir#53 ) <!-- Before submitting a PR, please read https://docs.deno.com/runtime/manual/references/contributing 1. Give the PR a descriptive title. Examples of good title: - fix(std/http): Fix race condition in server - docs(console): Update docstrings - feat(doc): Handle nested reexports Examples of bad title: - fix #7123 - update docs - fix bugs 2. Ensure there is a related issue and it is referenced in the PR text. 3. Ensure there are tests that cover the changes. 4. Ensure `cargo test` passes. 5. Ensure `./tools/format.js` passes without changing files. 6. Ensure `./tools/lint.js` passes. 7. Open as a draft PR if your work is still in progress. The CI won't run all steps, but you can add '[ci]' to a commit message to force it to. 8. If you would like to run the benchmarks on the CI, add the 'ci-bench' label. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adjusts the cache manifest to make the generated
manifest.jsonit more deterministic to improve the reproducability of vendored dependencies. The order of entries in the cache manifest previously depended on the order in which they were added.