Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(std): add Deno.totalMems #8312

Closed
wants to merge 3 commits into from
Closed

feat(std): add Deno.totalMems #8312

wants to merge 3 commits into from

Conversation

jopemachine
Copy link
Contributor

@jopemachine jopemachine commented Nov 9, 2020 •
edited
Loading

Related Issue

#3802

Usage

// It shows the total amount of memory on the local computer.
console.log(Deno.totalMems());

Notes

I'm a novice developer who is not familiar with open source yet.
I'd be grateful if you could give me any kind of advice :)

I'd like to contribute to creating more Deno's node compatibility modules.

@jopemachine jopemachine changed the title feat(std): Add totalMems feat(std): add totalMems Nov 9, 2020
@jopemachine jopemachine marked this pull request as draft November 9, 2020 08:21
@jopemachine jopemachine changed the title feat(std): add totalMems feat(std): add Deno.totalMems Nov 9, 2020
ry
ry reviewed Nov 9, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch, but this functionality is already supported by Deno.systemMemoryInfo().total. We'd gladly accept a patch to std/node/os.ts to use systemMemoryInfo().

@ry ry closed this Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jopemachine @ry