docs: improve manual around typescript #8139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitsonk
force-pushed
the
docs_typescript
branch
from
cab93a1 to
cb17bbc
Compare
kitsonk
force-pushed
the
docs_typescript
branch
from
cb17bbc to
38ec6a4
Compare
kitsonk
changed the title
|
Merge On Approval, Please |
bartlomieju
reviewed
Jan 19, 2021
cli/tsc_config.rs
Outdated
| @@ -64,6 +64,7 @@ impl Serialize for IgnoredCompilerOptions { | |||
| pub const IGNORED_COMPILER_OPTIONS: &[&str] = &[ | |||
| "allowSyntheticDefaultImports", | |||
| "allowUmdGlobalAccess", | |||
| "alwaysStrict", | |||
There was a problem hiding this comment.
This change makes tests fail:
---- module_graph::tests::test_graph_check_user_config stdout ----
Some(
IgnoredCompilerOptions {
items: [
"alwaysStrict",
],
maybe_path: Some(
"/Users/biwanczuk/dev/deno/cli/tests/module_graph/tsconfig_01.json",
),
},
)
thread 'module_graph::tests::test_graph_check_user_config' panicked at 'assertion failed: result_info.maybe_ignored_options.is_none()', cli/module_graph.rs:2302:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
lucacasonato
approved these changes
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the refactor of module graph infrastructure, it has been feeling like a right time to improve the manual around Deno and TypeScript.
Current work in progress.