BREAKING(cli/tsc): Enable isolatedModules by default #8050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay, thanks. |
|
It can be rebased now. |
nayeemrmn
force-pushed
the
isolated-modules-stable
branch
from
4441b86 to
9906047
Compare
kitsonk
suggested changes
Oct 23, 2020
There was a problem hiding this comment.
This is insufficient, as cli/tsc.rs will be retired after #8059 and #8060 are resolved (likely tomorrow). We need to update module_graph2.rs as well.
kitsonk
approved these changes
Oct 23, 2020
There was a problem hiding this comment.
LGTM, but I going to leave it for @bartlomieju to merge in light of coordinating other things regarding the 1.5 release.
kitsonk
pushed a commit
that referenced
this pull request
Dec 7, 2020
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 21, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Feb 1, 2021
adrianhopebailie
added a commit
to adrianhopebailie/tbl
that referenced
this pull request
Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7326.
Closes #7947, as code written for stable is once again compatible with
--unstable. Discussion: I strongly feel we should maintain this property, even if it means going straight to stable for future changes like this. Code written for--unstableis by design incompatible with stable -- having incompatibilities going the opposite way as well splits the ecosystem in half, generating a lot of headache and noise. Better to have everyone adapt at once.