-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): update to TypeScript 4.1 #7573
Conversation
Hey 👋 I was wondering what the plans are for Thank You |
@Skillz4Killz my personal opinion is that we don't enable it by default, as mentioned in the PR for it, the TypeScript core team says that they won't make it part of
While I agree it is a really useful feature for very strongly typed code, I don't think we can unleash it as a default on everyone. People can of course still enable it via use of the |
60db772
to
b356148
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Maybe we should hold off this update till Deno |
This PR updates Deno to TypeScript 4.1 beta in advance of TypeScript 4.1 being released to give an early view into any issues.
TypeScript 4.1 tightens up
Promise
definitions and there are quite a few instances in the code base where the type checking is failing due to this.