Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(imports): fix panic on unsupported scheme #5131

Merged
merged 2 commits into from
May 7, 2020
Merged

fix(imports): fix panic on unsupported scheme #5131

merged 2 commits into from
May 7, 2020

Conversation

bartlomieju
Copy link
Member

Closes #5048

This is a temporary fix; more holistic solution is related to #4781

ry
ry approved these changes May 7, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@bartlomieju bartlomieju merged commit 0ba90c8 into denoland:master May 7, 2020
@bartlomieju bartlomieju deleted the fix_dynamic_import_panic branch May 7, 2020 13:57
SASUKE40 pushed a commit to SASUKE40/deno that referenced this pull request May 7, 2020
@bartlomieju @SASUKE40
fix(imports): fix panic on unsupported scheme (denoland#5131)
1625ef9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dynamically importing URL with unsupported scheme raises Rust error
2 participants
@bartlomieju @ry