Fix path normalization in resolve_from_cwd()

[nayeemrmn]

Fixes #2718.

test.js:

Deno.readDirSync("..");
console.log("OK");

deno --no-prompt --allow-read="." test.js
Before: OK
After: error: Uncaught PermissionDenied: permission denied ...

[ry]

Cool - but is there some way we can get a unit test for this?

[nayeemrmn]

@ry Done. I wanted to add something to permissions.rs as well, but the whitelist checker in there assumes paths that are already normalised (which is handled prior in individual ops via resolve_from_cwd()) so they'd still fail. This could do with a refactor.

[ry]

Looks good - just a few comments --^

[ry]

LGTM

[txiklerr]

This bug remains unfixed :(

[kitsonk]

@ChiKler 😕 I just ran it and it works as expected:

❯ deno run --allow-read="." test.js
error: Uncaught PermissionDenied: read access to "/Users/kitsonk/github", run again with the --allow-read flag
    at processResponse (core.js:224:13)
    at Object.jsonOpSync (core.js:248:12)
    at Object.readDirSync (deno:cli/rt/30_fs.js:109:12)
    at file:///Users/kitsonk/github/test/test.js:1:6

Why do you think it isn't fixed?

[txiklerr]

@ChiKler 😕 I just ran it and it works as expected:

❯ deno run --allow-read="." test.js
error: Uncaught PermissionDenied: read access to "/Users/kitsonk/github", run again with the --allow-read flag
    at processResponse (core.js:224:13)
    at Object.jsonOpSync (core.js:248:12)
    at Object.readDirSync (deno:cli/rt/30_fs.js:109:12)
    at file:///Users/kitsonk/github/test/test.js:1:6

Why do you think it isn't fixed?

Here's an example (am I doing something wrong?):
https://github.com/ChiKler/-Deno-error-Uncaught-PermissionDenied-read-access-to-CWD-

[nayeemrmn]

@ChiKler I believe that's because you use copySync() from std, which (without a good reason) calls path.resolve() which requires CWD access. It shouldn't call path.resolve(), could you open an issue?