Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(fs/windows): stat - only open file once #27487

Merged
merged 3 commits into from
Dec 31, 2024
Merged

perf(fs/windows): stat - only open file once #27487

merged 3 commits into from
Dec 31, 2024
+22 −42

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Dec 29, 2024 •
edited
Loading

Even debug is way faster:

> cat main.cts
for (let i = 0; i < 100_000; i++) {
  Deno.statSync("b.txt");
}
> Measure-Command { deno run -A main.cts } | Select-Object -Property TotalMilliseconds    
          2684.68
> Measure-Command { ../deno/target/debug/deno run -A main.cts } | Select-Object -Property TotalMilliseconds
           988.55

dsherret
dsherret commented Dec 29, 2024
View reviewed changes
ext/fs/std_fs.rs
@@ -61,7 +61,7 @@ impl FileSystem for RealFs {
umask(Mode::from_bits_truncate(mask as mode_t))
} else {
// If no mask provided, we query the current. Requires two syscalls.
let prev = umask(Mode::from_bits_truncate(0o777));
let prev = umask(Mode::from_bits_truncate(0));
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also aligns with node.js: https://github.com/nodejs/node/blob/94191f7b0984410dcb134faa96cd1a0741d5e8f0/src/node_process_methods.cc#L243

@dsherret dsherret changed the title fix(windows): stat - close file handle on error fix(windows): stat - close file handle on error and only open file once Dec 29, 2024
dsherret
dsherret commented Dec 29, 2024
View reviewed changes
ext/fs/std_fs.rs

let result = get_dev(file_handle);
fsstat.dev = result?;
fsstat.dev = get_dev(file_handle)?;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also previously weren't closing the file_handle on error here.

@dsherret dsherret changed the title fix(windows): stat - close file handle on error and only open file once perf(windows): stat - only open file once Dec 29, 2024
@dsherret dsherret changed the title perf(windows): stat - only open file once perf(fs/windows): stat - only open file once Dec 29, 2024
@dsherret dsherret requested a review from bartlomieju December 29, 2024 17:12
bartlomieju
bartlomieju approved these changes Dec 31, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch

@dsherret dsherret merged commit 88bd5f0 into denoland:main Dec 31, 2024
17 checks passed
@dsherret dsherret deleted the fix_win_stat_close_file_handle_on_error branch December 31, 2024 16:29
dsherret added a commit that referenced this pull request Jan 9, 2025
@dsherret
perf(fs/windows): stat - only open file once (#27487)
95db6a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsherret @bartlomieju