fix: clear dep analysis when module loading is done #27204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
changed the title
bartlomieju
commented
Dec 4, 2024
|
Release |
dsherret
reviewed
Dec 4, 2024
nathanwhit
reviewed
Dec 4, 2024
dsherret
reviewed
Dec 4, 2024
cli/module_loader.rs
Outdated
| @@ -248,6 +248,9 @@ impl InFlightModuleLoadsTracker { | |||
| let parsed_source_cache = parsed_source_cache.clone(); | |||
| let timeout = self.cleanup_task_timeout; | |||
| let task_handle = tokio::spawn(async move { | |||
| // NB(bartlomieju): we use a timeout here, which is defined to 10s, | |||
There was a problem hiding this comment.
Nitpick: I feel like we don't have to add attribution to comments like this. It's already in the git blame.
There was a problem hiding this comment.
I removed it, but it only works as long as this code is not moved between files. Then it becomes easy to have a really hard time tracking who wrote the comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26663