Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(tests): Deprecate remaining usages of itest in check tests #26962

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore(tests): Deprecate remaining usages of itest in check tests #26962

wants to merge 1 commit into from
+13 −14

Conversation

ingalless
Copy link

@ingalless ingalless commented Nov 21, 2024 •
edited
Loading

This PR progresses #22907 by deprecating the usage of itest in tests/integration/check_tests.rs

@CLAassistant
Copy link

CLAassistant commented Nov 21, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ingalless
Copy link
Author

@MohammadSu1 @dsherret I was in the tests/integration/check_tests.rs file recently and noticed 2 more usages of itest that needed to be moved. I didn't know if these usages were left deliberately - were they? If not I can move this from out of draft 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ingalless @CLAassistant