fix: otel resiliency #26857
Merged
fix: otel resiliency #26857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devsnek
force-pushed
the
otel-resiliancy
branch
from
5628e84 to
09ef699
Compare
lucacasonato
approved these changes
Nov 13, 2024
bartlomieju
reviewed
Nov 14, 2024
runtime/lib.rs
Outdated
Comment on lines
144
to
145
| crate::ops::otel::flush(); | ||
| std::process::exit(code); |
There was a problem hiding this comment.
Can you please add std::process::exit to disallowed methods in clippy.toml files so someone doesn't accidently use it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving the breadth of collected data, and ensuring that the collected data is more likely to be successfully reported.
logcrate in more placeslogcrate to otelprocess::exitAlso adds a more robust testing framework, with a deterministic tracing setting.
Refs: #26852