fix: performance.timeOrigin #26787
Merged
fix: performance.timeOrigin #26787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devsnek
force-pushed
the
fix-perf-origin
branch
from
a0cc68f to
9ac868a
Compare
littledivy
pushed a commit
that referenced
this pull request
Nov 10, 2024
`performance.timeOrigin` was being set from when JS started executing, but `op_now` measures from an `std::time::Instant` stored in `OpState`, which is created at a completely different time. This caused `performance.timeOrigin` to be very incorrect. This PR corrects the origin and also cleans up some of the timer code. Compared to `Date.now()`, `performance`'s time origin is now consistently within 5us (0.005ms) of system time. 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
performance.timeOriginwas being set from when JS started executing, butop_nowmeasures from anstd::time::Instantstored inOpState, which is created at a completely different time. This causedperformance.timeOriginto be very incorrect. This PR corrects the origin and also cleans up some of the timer code.Compared to
Date.now(),performance's time origin is now consistently within 5us (0.005ms) of system time.