Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(add): better error message when adding package that only has pre-release versions #26724

Merged
merged 3 commits into from
Nov 5, 2024
Merged

fix(add): better error message when adding package that only has pre-release versions #26724

merged 3 commits into from
Nov 5, 2024

Conversation

nathanwhit
Copy link
Member

Fixes #26597

A small refactor as well to reduce some code duplication

@bartlomieju
Copy link
Member

bartlomieju commented Nov 4, 2024 •
edited
Loading

It appears there is no functional change in this PR. Could you add a new test or update existing one to exercise the exact scenario from the issue?

Scratch that, somehow I only saw a single commit.

@nathanwhit nathanwhit enabled auto-merge (squash) November 5, 2024 02:08
@nathanwhit nathanwhit merged commit 706b1df into denoland:main Nov 5, 2024
17 checks passed
@nathanwhit nathanwhit deleted the pre-release-error-message branch November 5, 2024 02:45
bartlomieju pushed a commit that referenced this pull request Nov 5, 2024
@nathanwhit @bartlomieju
fix(add): better error message when adding package that only has pre-…
09c9649 
…release versions (#26724)

Fixes #26597

A small refactor as well to reduce some code duplication
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@dsherret dsherret Awaiting requested review from dsherret

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve install error message when jsr package has only pre-release versions
2 participants
@nathanwhit @bartlomieju