Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/node): return this from http.Server.ref/unref() #26647

Merged
merged 1 commit into from
Oct 30, 2024
Merged

fix(ext/node): return this from http.Server.ref/unref() #26647

merged 1 commit into from
Oct 30, 2024

Conversation

nathanwhit
Copy link
Member

Fixes #26642

dsherret
dsherret approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nathanwhit nathanwhit enabled auto-merge (squash) October 30, 2024 19:41
@nathanwhit nathanwhit merged commit a346071 into denoland:main Oct 30, 2024
17 checks passed
@nathanwhit nathanwhit deleted the http-server-unref-return branch October 30, 2024 20:16
bartlomieju pushed a commit that referenced this pull request Nov 5, 2024
@nathanwhit @bartlomieju
fix(ext/node): return this from http.Server.ref/unref() (#26647)
0e2a731 
Fixes #26642
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@opentelemetry/exporter-prometheus fails on http server unref()
2 participants
@nathanwhit @dsherret