-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): add prefix hint when installing a package globally #26629
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @mbrdg, is there any chance you could add a test for this change?
Rookie mistake on my side, but I got a few questions regarding the test. First, I've tried to add a new test in Additionally, I've followed the logic from other tests by instantiating a |
@mbrdg that's correct, you can call |
d2cc655
to
84ceac0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great fix and nice work. Thank you @mbrdg
I believe that these changes caused a bug for |
closes #26545
Shows a hint when a package is installed globally, otherwise fallbacks to the existing implementation.