Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lsp): make missing import action fix infallible #26539

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

nayeemrmn
Copy link
Collaborator

@nayeemrmn nayeemrmn commented Oct 25, 2024

Fixes denoland/vscode_deno#1196. Fallback to the original action if import regex match etc. fails. Cleanup and flatten fix_ts_import_action() as well. We have no repro for the error, so no test.

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nayeemrmn nayeemrmn merged commit d92d2fe into denoland:main Oct 25, 2024
17 checks passed
@nayeemrmn nayeemrmn deleted the lsp-import-fix-infallible branch October 25, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting error: Request textDocument/codeAction failed.
2 participants