Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(npm): ensure scoped package name is encoded in URLs #26390

Merged
merged 9 commits into from
Oct 18, 2024
Merged

fix(npm): ensure scoped package name is encoded in URLs #26390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1c7d6a5
fix(npm): ensure scoped package name is encoded in URLs
marvinhagemeister Oct 18, 2024
d35478e
chore: update test fixtures
marvinhagemeister Oct 18, 2024
cdbb475
chore: update test fixture
marvinhagemeister Oct 18, 2024
225c1f0
chore: fix test fixture
marvinhagemeister Oct 18, 2024
655bd5d
chore: update more tests
marvinhagemeister Oct 18, 2024
befbd0d
chore: update more tests
marvinhagemeister Oct 18, 2024
4832901
chore: one more test
marvinhagemeister Oct 18, 2024
fa422c2
chore: fix more tests
marvinhagemeister Oct 18, 2024
938bade
chore: fix more tests
marvinhagemeister Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions cli/npm/managed/cache/registry_info.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,14 @@ impl RegistryInfoDownloader {

fn get_package_url(&self, name: &str) -> Url {
let registry_url = self.npmrc.get_registry_url(name);
// The '/' character in scoped package names "@scope/name" must be
// encoded for older third party registries. Newer registries and
// npm itself support both ways
// - encoded: https://registry.npmjs.org/@rollup%2fplugin-json
// - non-ecoded: https://registry.npmjs.org/@rollup/plugin-json
// To support as many third party registries as possible we'll
// always encode the '/' character.

// list of all characters used in npm packages:
// !, ', (, ), *, -, ., /, [0-9], @, [A-Za-z], _, ~
const ASCII_SET: percent_encoding::AsciiSet =
Expand All @@ -253,11 +261,14 @@ impl RegistryInfoDownloader {
.remove(b'*')
.remove(b'-')
.remove(b'.')
.remove(b'/')
.remove(b'@')
.remove(b'_')
.remove(b'~');
let name = percent_encoding::utf8_percent_encode(name, &ASCII_SET);
registry_url.join(&name.to_string()).unwrap()
registry_url
// Ensure that scoped package name percent encoding is lower cased
// to match npm.
.join(&name.to_string().replace("%2F", "%2f"))
.unwrap()
}
}
2 changes: 1 addition & 1 deletion tests/integration/compile_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1111,7 +1111,7 @@ console.log(getValue());"#,
.run();
output.assert_exit_code(0);
output.assert_matches_text(
r#"Download http://localhost:4260/@denotest/esm-basic
r#"Download http://localhost:4260/@denotest%2fesm-basic
Download http://localhost:4260/@denotest/esm-basic/1.0.0.tgz
Initialize @denotest/[email protected]
Check file:///[WILDCARD]/main.ts
Expand Down
36 changes: 18 additions & 18 deletions tests/integration/npm_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -876,7 +876,7 @@ fn auto_discover_lock_file() {
.run();
output
.assert_matches_text(
r#"Download http://localhost:4260/@denotest/bin
r#"Download http://localhost:4260/@denotest%2fbin
error: Integrity check failed for package: "npm:@denotest/[email protected]". Unable to verify that the package
is the same as when the lockfile was generated.

Expand Down Expand Up @@ -1058,10 +1058,10 @@ fn reload_info_not_found_cache_but_exists_remote() {
.run();
output.assert_matches_text(concat!(
"[UNORDERED_START]\n",
"Download http://localhost:4260/@denotest/esm-basic\n",
"Download http://localhost:4260/@denotest/esm-import-cjs-default\n",
"Download http://localhost:4260/@denotest/cjs-default-export\n",
"Download http://localhost:4260/@denotest/cjs-default-export/1.0.0.tgz\n",
"Download http://localhost:4260/@denotest%2fesm-basic\n",
"Download http://localhost:4260/@denotest%2fesm-import-cjs-default\n",
"Download http://localhost:4260/@denotest%2fcjs-default-export\n",
"Download http://localhost:4260/@denotestcjs-default-export/1.0.0.tgz\n",
"Download http://localhost:4260/@denotest/esm-basic/1.0.0.tgz\n",
"Download http://localhost:4260/@denotest/esm-import-cjs-default/1.0.0.tgz\n",
"[UNORDERED_END]\n",
Expand All @@ -1088,8 +1088,8 @@ fn reload_info_not_found_cache_but_exists_remote() {
let output = test_context.new_command().args("run main.ts").run();
output.assert_matches_text(concat!(
"[UNORDERED_START]\n",
"Download http://localhost:4260/@denotest/esm-import-cjs-default\n",
"Download http://localhost:4260/@denotest/cjs-default-export\n",
"Download http://localhost:4260/@denotest%2fesm-import-cjs-default\n",
"Download http://localhost:4260/@denotest%2fcjs-default-export\n",
"[UNORDERED_END]\n",
"Node esm importing node cjs\n[WILDCARD]",
));
Expand Down Expand Up @@ -1120,8 +1120,8 @@ fn reload_info_not_found_cache_but_exists_remote() {
let output = test_context.new_command().args("run main.ts").run();
output.assert_matches_text(concat!(
"[UNORDERED_START]\n",
"Download http://localhost:4260/@denotest/esm-import-cjs-default\n",
"Download http://localhost:4260/@denotest/cjs-default-export\n",
"Download http://localhost:4260/@denotest%2fesm-import-cjs-default\n",
"Download http://localhost:4260/@denotest%2fcjs-default-export\n",
"[UNORDERED_END]\n",
"Node esm importing node cjs\n[WILDCARD]",
));
Expand Down Expand Up @@ -1159,8 +1159,8 @@ fn reload_info_not_found_cache_but_exists_remote() {
let output = test_context.new_command().args("run main.ts").run();
output.assert_matches_text(concat!(
"[UNORDERED_START]\n",
"Download http://localhost:4260/@denotest/esm-import-cjs-default\n",
"Download http://localhost:4260/@denotest/cjs-default-export\n",
"Download http://localhost:4260/@denotest%2fesm-import-cjs-default\n",
"Download http://localhost:4260/@denotest%2fcjs-default-export\n",
"[UNORDERED_END]\n",
"[UNORDERED_START]\n",
"Initialize @denotest/[email protected]\n",
Expand Down Expand Up @@ -1196,9 +1196,9 @@ fn reload_info_not_found_cache_but_exists_remote() {
let output = test_context.new_command().args("run main.ts").run();
output.assert_matches_text(concat!(
"[UNORDERED_START]\n",
"Download http://localhost:4260/@denotest/esm-basic\n",
"Download http://localhost:4260/@denotest/esm-import-cjs-default\n",
"Download http://localhost:4260/@denotest/cjs-default-export\n",
"Download http://localhost:4260/@denotest%2fesm-basic\n",
"Download http://localhost:4260/@denotest%2fesm-import-cjs-default\n",
"Download http://localhost:4260/@denotest%2fcjs-default-export\n",
"[UNORDERED_END]\n",
"Initialize @denotest/[email protected]\n",
"Node esm importing node cjs\n[WILDCARD]",
Expand Down Expand Up @@ -1237,9 +1237,9 @@ fn reload_info_not_found_cache_but_exists_remote() {
let output = test_context.new_command().args("run main.ts").run();
output.assert_matches_text(concat!(
"[UNORDERED_START]\n",
"Download http://localhost:4260/@denotest/cjs-default-export\n",
"Download http://localhost:4260/@denotest/esm-basic\n",
"Download http://localhost:4260/@denotest/esm-import-cjs-default\n",
"Download http://localhost:4260/@denotest%2fcjs-default-export\n",
"Download http://localhost:4260/@denotest%2fesm-basic\n",
"Download http://localhost:4260/@denotest%2fesm-import-cjs-default\n",
"[UNORDERED_END]\n",
"Node esm importing node cjs\n[WILDCARD]",
));
Expand Down Expand Up @@ -1419,7 +1419,7 @@ fn top_level_install_package_json_explicit_opt_in() {
temp_dir.write("main.ts", "console.log(5);");
let output = test_context.new_command().args("cache main.ts").run();
output.assert_matches_text(concat!(
"Download http://localhost:4260/@denotest/esm-basic\n",
"Download http://localhost:4260/@denotest%2fesm-basic\n",
"Download http://localhost:4260/@denotest/esm-basic/1.0.0.tgz\n",
"Initialize @denotest/[email protected]\n",
));
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/run_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -898,7 +898,7 @@ fn lock_redirects() {
.run()
.assert_matches_text(concat!(
"Download http://localhost:4545/echo.ts\n",
"Download http://localhost:4260/@denotest/esm-basic\n",
"Download http://localhost:4260/@denotest%2fesm-basic\n",
"Download http://localhost:4260/@denotest/esm-basic/1.0.0.tgz\n",
"Hi, there",
));
Expand Down
2 changes: 1 addition & 1 deletion tests/specs/add/dev/add.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Add npm:@denotest/[email protected]
Download http://localhost:4260/@denotest/esm-basic
Download http://localhost:4260/@denotest%2fesm-basic
Download http://localhost:4260/@denotest/esm-basic/1.0.0.tgz
Initialize @denotest/[email protected]
2 changes: 1 addition & 1 deletion tests/specs/add/exact_version/npm_add.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Add npm:@denotest/[email protected]
Download http://localhost:4260/@denotest/esm-basic
Download http://localhost:4260/@denotest%2fesm-basic
Download http://localhost:4260/@denotest/esm-basic/1.0.0.tgz
2 changes: 1 addition & 1 deletion tests/specs/add/only_unstable_versions/add.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Add npm:@denotest/[email protected]
Download http://localhost:4260/@denotest/unstable
Download http://localhost:4260/@denotest%2funstable
Download http://localhost:4260/@denotest/unstable/1.0.0-beta.1.tgz
4 changes: 2 additions & 2 deletions tests/specs/add/package_json_and_deno_json/add.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
Add npm:@denotest/[email protected]
Add jsr:@denotest/[email protected]
Add npm:@denotest/[email protected]
Download http://localhost:4260/@denotest/esm-basic
Download http://localhost:4260/@denotest%2fesm-basic
Download http://localhost:4260/@denotest/esm-basic/1.0.0.tgz
Download http://localhost:4260/@denotest/say-hello
Download http://localhost:4260/@denotest%2fsay-hello
Download http://localhost:4260/@denotest/say-hello/1.0.0.tgz
Initialize @denotest/[email protected]
Initialize @denotest/[email protected]
Expand Down
2 changes: 1 addition & 1 deletion tests/specs/add/package_json_and_deno_json/add_esm_basic.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Add npm:@denotest/[email protected]
Download http://localhost:4260/@denotest/esm-basic
Download http://localhost:4260/@denotest%2fesm-basic
Download http://localhost:4260/@denotest/esm-basic/1.0.0.tgz
Initialize @denotest/[email protected]
2 changes: 1 addition & 1 deletion tests/specs/bench/package_json/install.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Download http://localhost:4260/@denotest/esm-basic
Download http://localhost:4260/@denotest%2fesm-basic
Download http://localhost:4260/@denotest/esm-basic/1.0.0.tgz
Initialize @denotest/[email protected]
2 changes: 1 addition & 1 deletion tests/specs/cache/package_json/main.cache.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Download http://localhost:4260/@denotest/esm-basic
Download http://localhost:4260/@denotest%2fesm-basic
Download http://localhost:4260/@denotest/esm-basic/1.0.0.tgz
2 changes: 1 addition & 1 deletion tests/specs/check/cjs_default_export/main.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Download http://localhost:4260/@denotest/cjs-default-export
Download http://localhost:4260/@denotest%2fcjs-default-export
Download http://localhost:4260/@denotest/cjs-default-export/1.0.0.tgz
Check file:///[WILDCARD]/main.ts
error: TS2322 [ERROR]: Type 'number' is not assignable to type 'string'.
Expand Down
2 changes: 1 addition & 1 deletion tests/specs/check/package_json/install.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Download http://localhost:4260/@denotest/esm-basic
Download http://localhost:4260/@denotest%2fesm-basic
Download http://localhost:4260/@denotest/esm-basic/1.0.0.tgz
Initialize @denotest/[email protected]
2 changes: 1 addition & 1 deletion tests/specs/check/package_json_auto_install/check.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Download http://localhost:4260/@denotest/esm-basic
Download http://localhost:4260/@denotest%2fesm-basic
Download http://localhost:4260/@denotest/esm-basic/1.0.0.tgz
Initialize @denotest/[email protected]
Check file://[WILDCARD]/main.ts
2 changes: 1 addition & 1 deletion tests/specs/check/package_json_fail_check/install.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Download http://localhost:4260/@denotest/esm-basic
Download http://localhost:4260/@denotest%2fesm-basic
Download http://localhost:4260/@denotest/esm-basic/1.0.0.tgz
Initialize @denotest/[email protected]
2 changes: 1 addition & 1 deletion tests/specs/check/package_json_with_deno_json/install.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Download http://localhost:4260/@denotest/esm-basic
Download http://localhost:4260/@denotest%2fesm-basic
Download http://localhost:4260/@denotest/esm-basic/1.0.0.tgz
Initialize @denotest/[email protected]
4 changes: 2 additions & 2 deletions tests/specs/compile/npmrc_byonm/install.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[UNORDERED_START]
Download http://localhost:4261/@denotest/basic
Download http://localhost:4262/@denotest2/basic
Download http://localhost:4261/@denotest%2fbasic
Download http://localhost:4262/@denotest2%2fbasic
Download http://localhost:4261/@denotest/basic/1.0.0.tgz
Download http://localhost:4262/@denotest2/basic/1.0.0.tgz
Initialize @denotest2/[email protected]
Expand Down
2 changes: 1 addition & 1 deletion tests/specs/info/package_json_basic/install.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Download http://localhost:4260/@denotest/esm-basic
Download http://localhost:4260/@denotest%2fesm-basic
Download http://localhost:4260/@denotest/esm-basic/1.0.0.tgz
Initialize @denotest/[email protected]
2 changes: 1 addition & 1 deletion tests/specs/install/future_install_global/install.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Download http://localhost:4260/@denotest/esm-basic
Download http://localhost:4260/@denotest%2fesm-basic
Download http://localhost:4260/@denotest/esm-basic/1.0.0.tgz
✅ Successfully installed deno-test-bin[WILDCARD]
[WILDCARD]
2 changes: 1 addition & 1 deletion tests/specs/install/future_install_local_add_deno/install.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Add npm:@denotest/[email protected]
Download http://localhost:4260/@denotest/esm-basic
Download http://localhost:4260/@denotest%2fesm-basic
Download http://localhost:4260/@denotest/esm-basic/1.0.0.tgz
2 changes: 1 addition & 1 deletion tests/specs/install/future_install_local_add_npm/install.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Add npm:@denotest/[email protected]
Download http://localhost:4260/@denotest/esm-basic
Download http://localhost:4260/@denotest%2fesm-basic
Download http://localhost:4260/@denotest/esm-basic/1.0.0.tgz
Initialize @denotest/[email protected]
2 changes: 1 addition & 1 deletion tests/specs/install/future_install_local_deno/install.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Download http://localhost:4545/subdir/print_hello.ts
Download http://127.0.0.1:4250/@denotest/add/meta.json
Download http://127.0.0.1:4250/@denotest/add/1.0.0_meta.json
Download http://127.0.0.1:4250/@denotest/add/1.0.0/mod.ts
Download http://localhost:4260/@denotest/esm-basic
Download http://localhost:4260/@denotest%2fesm-basic
Download http://localhost:4260/@denotest/esm-basic/1.0.0.tgz
Download http://127.0.0.1:4250/@std/testing/1.0.0/bdd.ts
Download http://127.0.0.1:4250/@std/testing/1.0.0/types.ts
Expand Down
2 changes: 1 addition & 1 deletion tests/specs/install/future_install_node_modules/install.out
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion tests/specs/install/install_add_dep_existing/install.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Add npm:@denotest/[email protected]
Download http://localhost:4260/@denotest/esm-basic
Download http://localhost:4260/@denotest%2fesm-basic
Download http://localhost:4260/@denotest/esm-basic/1.0.0.tgz
Initialize @denotest/[email protected]
2 changes: 1 addition & 1 deletion tests/specs/install/install_add_dev/install.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Add npm:@denotest/[email protected]
Download http://localhost:4260/@denotest/esm-basic
Download http://localhost:4260/@denotest%2fesm-basic
Download http://localhost:4260/@denotest/esm-basic/1.0.0.tgz
Initialize @denotest/[email protected]
2 changes: 1 addition & 1 deletion tests/specs/install/install_add_dev_existing/install.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Add npm:@denotest/[email protected]
Download http://localhost:4260/@denotest/esm-basic
Download http://localhost:4260/@denotest%2fesm-basic
Download http://localhost:4260/@denotest/esm-basic/1.0.0.tgz
Initialize @denotest/[email protected]
2 changes: 1 addition & 1 deletion tests/specs/install/install_deprecated_package/install.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Add npm:@denotest/[email protected]
Download http://localhost:4260/@denotest/deprecated-package
Download http://localhost:4260/@denotest%2fdeprecated-package
Download http://localhost:4260/@denotest/deprecated-package/1.0.0.tgz
Initialize @denotest/[email protected]
Warning The following packages are deprecated:
Expand Down
2 changes: 1 addition & 1 deletion tests/specs/install/install_entrypoint/install.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[UNORDERED_START]
Download http://127.0.0.1:4250/@denotest/add/meta.json
Download http://localhost:4260/@denotest/esm-basic
Download http://localhost:4260/@denotest%2fesm-basic
Download http://127.0.0.1:4250/@denotest/add/1.0.0_meta.json
Download http://127.0.0.1:4250/@denotest/add/1.0.0/mod.ts
Download http://localhost:4260/@denotest/esm-basic/1.0.0.tgz
Expand Down
4 changes: 2 additions & 2 deletions tests/specs/install/install_entrypoint/lifecycle.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[UNORDERED_START]
Download http://localhost:4260/@denotest/node-lifecycle-scripts
Download http://localhost:4260/@denotest/bin
Download http://localhost:4260/@denotest%2fnode-lifecycle-scripts
Download http://localhost:4260/@denotest%2fbin
Download http://localhost:4260/@denotest/node-lifecycle-scripts/1.0.0.tgz
Download http://localhost:4260/@denotest/bin/1.0.0.tgz
Initialize @denotest/[email protected]
Expand Down
2 changes: 1 addition & 1 deletion tests/specs/install/non_existent_optional_peer/install.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[UNORDERED_START]
Download http://localhost:4260/@denotest/non-existent-optional-peer
Download http://localhost:4260/@denotest%2fnon-existent-optional-peer
Download http://localhost:4260/uWebSockets.js
Download http://localhost:4260/@denotest/non-existent-optional-peer/1.0.0.tgz
[UNORDERED_END]
Expand Down
2 changes: 1 addition & 1 deletion tests/specs/install/workspace_member_with_tag_dep/install.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Download http://localhost:4260/@denotest/esm-basic
Download http://localhost:4260/@denotest%2fesm-basic
Download http://localhost:4260/@denotest/esm-basic/1.0.0.tgz
Initialize @denotest/[email protected]
2 changes: 1 addition & 1 deletion tests/specs/lockfile/frozen_lockfile/frozen_new_dep_dynamic_npm.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Download http://localhost:4260/@denotest/subtract
Download http://localhost:4260/@denotest%2fsubtract
error: Uncaught (in promise) TypeError: The lockfile is out of date. Run `deno install --frozen=false`, or rerun with `--frozen=false` to update it.
changes:
4 | - "npm:@denotest/add@1": "1.0.0"
Expand Down
2 changes: 1 addition & 1 deletion tests/specs/lockfile/frozen_lockfile/frozen_new_dep_run.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Download http://localhost:4260/@denotest/subtract
Download http://localhost:4260/@denotest%2fsubtract
error: The lockfile is out of date. Run `deno install --frozen=false`, or rerun with `--frozen=false` to update it.
changes:
4 | - "npm:@denotest/add@1": "1.0.0"
Expand Down
2 changes: 1 addition & 1 deletion tests/specs/lockfile/frozen_lockfile/frozen_package_json_changed.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Download http://localhost:4260/@denotest/bin
Download http://localhost:4260/@denotest%2fbin
error: The lockfile is out of date. Run `deno install --frozen=false`, or rerun with `--frozen=false` to update it.
changes:
4 | - "npm:@denotest/add@1": "1.0.0"
Expand Down
2 changes: 1 addition & 1 deletion tests/specs/lockfile/frozen_lockfile/no_lockfile_run.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Download http://localhost:4260/@denotest/add
Download http://localhost:4260/@denotest%2fadd
error: The lockfile is out of date. Run `deno install --frozen=false`, or rerun with `--frozen=false` to update it.
changes:
1 | -
Expand Down
2 changes: 1 addition & 1 deletion tests/specs/lockfile/only_package_json/install.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Download http://localhost:4260/@denotest/esm-basic
Download http://localhost:4260/@denotest%2fesm-basic
Download http://localhost:4260/@denotest/esm-basic/1.0.0.tgz
Initialize @denotest/[email protected]
2 changes: 1 addition & 1 deletion tests/specs/node/cjs_reexport_same_specifier_in_sub_folder/main.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Download http://localhost:4260/@denotest/cjs-reexport-same-specifier-in-sub-folder
Download http://localhost:4260/@denotest%2fcjs-reexport-same-specifier-in-sub-folder
Download http://localhost:4260/@denotest/cjs-reexport-same-specifier-in-sub-folder/1.0.0.tgz
[Module: null prototype] {
default: { main: [Getter], sub: [Getter] },
Expand Down
4 changes: 2 additions & 2 deletions tests/specs/npm/adding_npm_dep_in_dynamic_import/main.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
Download http://localhost:4260/@denotest/add
Download http://localhost:4260/@denotest%2fadd
Download http://localhost:4260/@denotest/add/1.0.0.tgz
Initialize @denotest/[email protected]
3
Download http://localhost:4260/@denotest/subtract
Download http://localhost:4260/@denotest%2fsubtract
Download http://localhost:4260/@denotest/subtract/1.0.0.tgz
Initialize @denotest/[email protected]
1
4 changes: 2 additions & 2 deletions tests/specs/npm/bin_entries_prefer_closer/install.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[UNORDERED_START]
Download http://localhost:4260/@denotest/transitive-bin
Download http://localhost:4260/@denotest/bin
Download http://localhost:4260/@denotest%2ftransitive-bin
Download http://localhost:4260/@denotest%2fbin
Download http://localhost:4260/@denotest/bin/1.0.0.tgz
Download http://localhost:4260/@denotest/transitive-bin/1.0.0.tgz
Download http://localhost:4260/@denotest/bin/0.7.0.tgz
Expand Down
2 changes: 1 addition & 1 deletion tests/specs/npm/check_all/check_errors/main_all.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Download http://localhost:4260/@denotest/check-error
Download http://localhost:4260/@denotest%2fcheck-error
Download http://localhost:4260/@denotest/check-error/1.0.0.tgz
Check file:///[WILDCARD]/check_errors/main.ts
error: TS2506 [ERROR]: 'Class1' is referenced directly or indirectly in its own base expression.
Expand Down
2 changes: 1 addition & 1 deletion tests/specs/npm/check_all/check_errors/main_local.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Download http://localhost:4260/@denotest/check-error
Download http://localhost:4260/@denotest%2fcheck-error
Download http://localhost:4260/@denotest/check-error/1.0.0.tgz
Check file:///[WILDCARD]/check_errors/main.ts
error: TS2339 [ERROR]: Property 'Asdf' does not exist on type 'typeof import("file:///[WILDCARD]/@denotest/check-error/1.0.0/index.d.ts")'.
Expand Down
2 changes: 1 addition & 1 deletion tests/specs/npm/check_local/check_errors/main_all.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Download http://localhost:4260/@denotest/check-error
Download http://localhost:4260/@denotest%2fcheck-error
Download http://localhost:4260/@denotest/check-error/1.0.0.tgz
Check file:///[WILDCARD]/check_errors/main.ts
error: TS2506 [ERROR]: 'Class1' is referenced directly or indirectly in its own base expression.
Expand Down
2 changes: 1 addition & 1 deletion tests/specs/npm/check_local/check_errors/main_local.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Download http://localhost:4260/@denotest/check-error
Download http://localhost:4260/@denotest%2fcheck-error
Download http://localhost:4260/@denotest/check-error/1.0.0.tgz
Check file:///[WILDCARD]/check_errors/main.ts
error: TS2339 [ERROR]: Property 'Asdf' does not exist on type 'typeof import("file:///[WILDCARD]/@denotest/check-error/1.0.0/index.d.ts")'.
Expand Down
2 changes: 1 addition & 1 deletion tests/specs/npm/check_package_file_dts_dmts_dcts/file_dts_dmts_dcts/main.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Download http://localhost:4260/@denotest/file-dts-dmts-dcts
Download http://localhost:4260/@denotest%2ffile-dts-dmts-dcts
Download http://localhost:4260/@denotest/file-dts-dmts-dcts/1.0.0.tgz
Check file:///[WILDCARD]/main.ts
error: TS2322 [ERROR]: Type '5' is not assignable to type '"dts"'.
Expand Down
Loading