Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(task): support tasks with colons in name in deno run #25233

Merged
merged 1 commit into from
Aug 27, 2024
Merged

fix(task): support tasks with colons in name in deno run #25233

merged 1 commit into from
Aug 27, 2024

Conversation

marvinhagemeister
Copy link
Contributor

Fix task names containing a colon not being found with deno run. We were only checking for a module not found error message, but strings containing a colon throw a different error.

Fixes #25232

satyarohith
satyarohith approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@satyarohith satyarohith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

LGTM

@marvinhagemeister marvinhagemeister merged commit 7e68cce into main Aug 27, 2024
17 checks passed
@marvinhagemeister marvinhagemeister deleted the run-colon-task branch August 27, 2024 09:27
@marvinhagemeister marvinhagemeister mentioned this pull request Aug 28, 2024
Closed
lucacasonato pushed a commit that referenced this pull request Aug 29, 2024
@marvinhagemeister @lucacasonato
fix(task): support tasks with colons in name in deno run (#25233)
1d2116d 
Fix task names containing a colon not being found with `deno run`. We
were only checking for a `module not found` error message, but strings
containing a colon throw a different error.

Fixes #25232
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satyarohith satyarohith satyarohith approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deno run cannot run task name with colons
2 participants
@marvinhagemeister @satyarohith