Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(publish): ensure provenance is spec compliant #25200

Merged
merged 3 commits into from
Aug 31, 2024

Conversation

bobcallaway
Copy link
Contributor

Fixes: #25199

Ensures that for the SLSA provenance document generated on publishing, subject is an array of ResourceDescriptor objects per the in-toto specification requirements.

@CLAassistant
Copy link

CLAassistant commented Aug 25, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@littledivy
Copy link
Member

Need to update JSR registry before merging: jsr-io/jsr#699

@littledivy littledivy added this to the 2.0.0 milestone Aug 25, 2024
github-merge-queue bot pushed a commit to jsr-io/jsr that referenced this pull request Aug 26, 2024
@dsherret dsherret enabled auto-merge (squash) August 31, 2024 15:19
@dsherret dsherret added the backport:1.46 This PR needs to be backported to v1.46 branch label Aug 31, 2024
@dsherret dsherret merged commit 3a63572 into denoland:main Aug 31, 2024
17 checks passed
lucacasonato pushed a commit that referenced this pull request Sep 4, 2024
Fixes: #25199 

Ensures that for the SLSA provenance document generated on publishing,
`subject` is an array of ResourceDescriptor objects per the in-toto
specification
[requirements](https://github.com/in-toto/attestation/blob/main/spec/v1/statement.md#fields).

---------

Signed-off-by: Bob Callaway <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:1.46 This PR needs to be backported to v1.46 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SLSA provenance generated does not conform to the in-toto specification
4 participants