Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(install): Use relative symlinks in deno install #25164

Merged
merged 5 commits into from
Aug 22, 2024
Merged

fix(install): Use relative symlinks in deno install #25164

merged 5 commits into from
Aug 22, 2024
+70 −25

Conversation

nathanwhit
Copy link
Member

Fixes #25161

dsherret
dsherret approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cli/npm/managed/resolvers/local.rs Show resolved Hide resolved
@nathanwhit nathanwhit enabled auto-merge (squash) August 22, 2024 21:53
@nathanwhit nathanwhit merged commit f606402 into denoland:main Aug 22, 2024
17 checks passed
lucacasonato pushed a commit that referenced this pull request Aug 29, 2024
@nathanwhit @lucacasonato
fix(install): Use relative symlinks in deno install (#25164)
1a1a7af 
Fixes #25161
@lucacasonato lucacasonato mentioned this pull request Sep 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

symlinks created by deno install should not be absolute
2 participants
@nathanwhit @dsherret