-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(unstable): ability to use a local copy of jsr packages #25068
Conversation
…ecause it's significantly more complicated than I expected
3bfaf2f
to
2cc61f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'm not sure about the name either, but I think we can safely land it as unstable feature for now.
if self.warned_pkgs.insert(reference.req().clone()) { | ||
log::warn!("{} {}\n at {}", colors::yellow("Warning"), diagnostic, referrer_range); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the message say that this patch was not used due to not matching constraints?
Warning Workspace member '@denotest/[email protected]' was not used because it did not match '@denotest/add@1' | ||
at file:///[WILDLINE]/mod.ts:1:21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it does :)
Allows specifying the directory to another package or workspace similar to patch in cargo (https://doc.rust-lang.org/cargo/reference/overriding-dependencies.html).
Going to land this as unstable in order to get feedback. I'm not really sure about the name because it sounds like it will be confusing with the concept of patching dependencies in npm or patching the vendor folder.
Closes #23412
Closes #24931