Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/node): createBrotliCompress params #24984

Merged
merged 2 commits into from
Aug 11, 2024
Merged

fix(ext/node): createBrotliCompress params #24984

merged 2 commits into from
Aug 11, 2024

Conversation

littledivy
Copy link
Member

Fixes #24416

@littledivy littledivy mentioned this pull request Aug 11, 2024
Closed
marvinhagemeister
marvinhagemeister approved these changes Aug 11, 2024
View reviewed changes
Copy link
Contributor

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@littledivy littledivy merged commit feba133 into denoland:main Aug 11, 2024
17 checks passed
@littledivy littledivy deleted the fox_create_brotli_params branch August 11, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Panic with size-limit package
2 participants
@littledivy @marvinhagemeister