Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rename --unstable-hmr to --watch-hmr #24975

Merged
merged 3 commits into from
Aug 11, 2024

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Aug 9, 2024

This commit stabilizes HMR functionality and renames
--unstable-hmr to --watch-hmr. The --unstable-hmr
flag is still working, but hidden from the help output.
It will be removed in Deno 2.

Once #24958 lands
we should improve grouping of --watch and --watch-hmr
flags.

@bartlomieju bartlomieju added this to the 1.46 milestone Aug 9, 2024
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep a secret unstable-watch alias so we don’t break anyone?

@bartlomieju
Copy link
Member Author

Should we keep a secret unstable-watch alias so we don’t break anyone?

Yeah, totally. Forgot about that.

@bartlomieju bartlomieju requested a review from ry August 11, 2024 21:34
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 004b74c into denoland:main Aug 11, 2024
17 checks passed
@bartlomieju bartlomieju deleted the rename_hmr_flag branch August 11, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants