Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/node): ed25519 signing and cipheriv autopadding fixes #24957

Merged
merged 6 commits into from
Aug 9, 2024
Merged

fix(ext/node): ed25519 signing and cipheriv autopadding fixes #24957

merged 6 commits into from
Aug 9, 2024

Conversation

lucacasonato
Copy link
Member

@lucacasonato lucacasonato commented Aug 8, 2024 •
edited by littledivy
Loading

Changes:

  • Return auth tag for GCM ciphers from auto padding shortcircuit.
  • Use ring for ed25519 signing

littledivy
littledivy approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@littledivy littledivy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@littledivy littledivy changed the title fix(ext/node): ed25519 signing, cipheriv.final fixes fix(ext/node): ed25519 signing and cipheriv.final fixes Aug 9, 2024
@littledivy littledivy changed the title fix(ext/node): ed25519 signing and cipheriv.final fixes fix(ext/node): ed25519 signing and cipheriv autopadding fixes Aug 9, 2024
@lucacasonato lucacasonato merged commit fc02303 into main Aug 9, 2024
17 checks passed
@lucacasonato lucacasonato deleted the ed25519_fix branch August 9, 2024 10:58
@littledivy littledivy mentioned this pull request Aug 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@littledivy littledivy littledivy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucacasonato @littledivy