Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lint): Support linting tsx/jsx from stdin #24955

Merged
merged 11 commits into from
Aug 19, 2024
Merged

fix(lint): Support linting tsx/jsx from stdin #24955

merged 11 commits into from
Aug 19, 2024

Conversation

yazan-abdalrahman
Copy link
Contributor

Add --ext flag to deno lint to support linting TSX/JSX from stdin
fix #24854

@yazan-abdalrahman
Copy link
Contributor Author

@lucacasonato @bartlomieju

@yazan-abdalrahman yazan-abdalrahman mentioned this pull request Aug 12, 2024
Closed
@yazan-abdalrahman
Copy link
Contributor Author

@dsherret please review this PR?

dsherret
dsherret requested changes Aug 15, 2024
View reviewed changes
cli/args/flags.rs Outdated Show resolved Hide resolved
@dsherret dsherret added this to the 1.46 milestone Aug 15, 2024
dsherret
dsherret approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

In the future, I'd recommend writing a test to exercise the change (I just added one). For example, in this case the displayed file path was showing as ".ts" instead of ".jsx"

@dsherret dsherret enabled auto-merge (squash) August 19, 2024 20:05
@dsherret dsherret merged commit 4285cb3 into denoland:main Aug 19, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.46
Development

Successfully merging this pull request may close these issues.

Lint tsx and jsx from stdin
2 participants
@yazan-abdalrahman @dsherret