fix(ext/fetch): include URL and error details on fetch failures #24910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magurotuna
force-pushed
the
magurotuna/improve-fetch-error
branch
from
9f7cb28
to
47dbb42
Compare
magurotuna
commented
Aug 7, 2024
Comment on lines
+1097
to
+1125
| #[derive(Debug)] | ||
| pub struct ClientSendError { | ||
| uri: Uri, | ||
| source: hyper_util::client::legacy::Error, | ||
| } | ||
|
|
||
| impl ClientSendError { | ||
| pub fn is_connect_error(&self) -> bool { | ||
| self.source.is_connect() | ||
| } | ||
| } | ||
|
|
||
| impl std::fmt::Display for ClientSendError { | ||
| fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result { | ||
| write!( | ||
| f, | ||
| "error sending request for url ({uri}): {source}", | ||
| uri = self.uri, | ||
| // NOTE: we can use `std::error::Report` instead once it's stabilized. | ||
| source = error_reporter::Report::new(&self.source), | ||
| ) | ||
| } | ||
| } | ||
|
|
||
| impl std::error::Error for ClientSendError { | ||
| fn source(&self) -> Option<&(dyn std::error::Error + 'static)> { | ||
| Some(&self.source) | ||
| } | ||
| } |
There was a problem hiding this comment.
For reviewers: this custom error type is needed because we need to preserve the original error so we can later access with std::error::Error::source to get hyper::Error, while having to adjust the error message format using error_reporter::Report.
bartlomieju
approved these changes
Aug 7, 2024
Yeah I thought the same, but the crate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves error messages that
fetchgenerates on failure.Fixes #24835