feat: deno upgrade --rc
#24905
feat: deno upgrade --rc
#24905
Conversation
release-2-rc.txt
Outdated
| @@ -0,0 +1,2 @@ | |||
| 0b8f8d0f60ad0ff501860bead0fd333634560d30 v1.46.0-rc.0 | |||
There was a problem hiding this comment.
Remove, add a GH actions script that appends to a file like this in GCP bucket
| )) | ||
| ); | ||
| if !upgrade_flags.canary { | ||
| print_release_notes(version::deno(), &install_version); | ||
| if !requested_version.is_canary() { |
There was a problem hiding this comment.
Decide if we're gonna do RC blog post/and or link to notes
| @@ -864,13 +1035,14 @@ struct CheckVersionFile { | |||
| pub last_checked: chrono::DateTime<chrono::Utc>, | |||
| pub current_version: String, | |||
| pub latest_version: String, | |||
| pub current_release_channel: ReleaseChannel, | |||
There was a problem hiding this comment.
I opted to store this info in the latest.txt file so we don't have to hit remote server to display a banner. Works quite well 👍
cli/tools/upgrade.rs
Outdated
| @@ -725,6 +890,7 @@ fn get_latest_version_url( | |||
| ReleaseChannel::Canary => { | |||
| Cow::Owned(format!("canary-{target_tuple}-latest.txt")) | |||
| } | |||
| ReleaseChannel::Rc => Cow::Borrowed("release-2-rc.txt"), | |||
There was a problem hiding this comment.
Since this PR provides a generic solution to RCs it's probably best to rename it to release-rc.txt
|
Should we also add |
We can, but I think I want to try this mechanism first for a few days. I can do it once we're happy with it. |
|
|
||
| let is_current_exe_an_rc = rc_versions | ||
| .iter() | ||
| .any(|(hash, _)| hash == version::GIT_COMMIT_HASH); |
There was a problem hiding this comment.
This is realy hacky, but ok for the first pass.
This reverts commit 3c70b94.
Flag name open to bike-shedding.