Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compile): adhoc codesign mach-o by default #24824

Merged
merged 2 commits into from
Aug 1, 2024
Merged

fix(compile): adhoc codesign mach-o by default #24824

merged 2 commits into from
Aug 1, 2024

Conversation

littledivy
Copy link
Member

Missed to add this in #24604

@littledivy littledivy enabled auto-merge (squash) August 1, 2024 07:36
lucacasonato
lucacasonato reviewed Aug 1, 2024
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not have any tests that do compile followed by exec? They should have caught this, right?

@littledivy
Copy link
Member Author

littledivy commented Aug 1, 2024 •
edited
Loading

I'll add codesign --verify which should be good enough in the CI. The binary should normally crash if signature is invalid but CI kernel allows it apparently.

@littledivy littledivy merged commit 9f27bf9 into denoland:main Aug 1, 2024
17 checks passed
@littledivy littledivy deleted the compile-buildandsign branch August 1, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@littledivy @lucacasonato