Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/crypto): respect offsets when writing into ab views in randomFillSync #24816

Merged
merged 2 commits into from
Aug 1, 2024
Merged

fix(ext/crypto): respect offsets when writing into ab views in randomFillSync #24816

merged 2 commits into from
Aug 1, 2024

Conversation

lucacasonato
Copy link
Member

Fixes #24799

nathanwhit
nathanwhit approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@nathanwhit nathanwhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

littledivy
littledivy approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucacasonato lucacasonato merged commit f1fc708 into denoland:main Aug 1, 2024
17 checks passed
@lucacasonato lucacasonato deleted the respect_offset_randomfillsync branch August 1, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanwhit nathanwhit nathanwhit approved these changes

@littledivy littledivy littledivy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WASM might be broken ?
3 participants
@lucacasonato @nathanwhit @littledivy