Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext/webgpu): assign missing constants property of shader about GPUDevice.createRenderPipeline[Async] #24803

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

Hajime-san
Copy link
Contributor

fixes #24287

@Hajime-san Hajime-san changed the title fix(ext/webgpu): assign missing constants property of shader in the internal of GPUDevice.createRenderPipeline[Async] fix(ext/webgpu): assign missing constants property of shader about GPUDevice.createRenderPipeline[Async] Jul 31, 2024
Copy link
Member

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@crowlKats crowlKats merged commit ba93278 into denoland:main Aug 1, 2024
17 checks passed
@Hajime-san Hajime-san deleted the fix-webgpu-createrenderpipeline branch August 1, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GPUDevice.createRenderPipeline[Async] ignores constants
2 participants