Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lsp): registry completions for import-mapped specifiers #24792

Merged
merged 4 commits into from
Jul 30, 2024
Merged

feat(lsp): registry completions for import-mapped specifiers #24792

merged 4 commits into from
Jul 30, 2024

Conversation

nayeemrmn
Copy link
Collaborator

Closes #22566

dsherret
dsherret reviewed Jul 30, 2024
View reviewed changes
cli/lsp/registries.rs Outdated Show resolved Hide resolved
dsherret
dsherret approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cli/lsp/registries.rs Outdated Show resolved Hide resolved
@nayeemrmn nayeemrmn merged commit 3659781 into denoland:main Jul 30, 2024
17 checks passed
@nayeemrmn nayeemrmn deleted the lsp-registry-completions-import-map branch July 30, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

@nathanwhit nathanwhit Awaiting requested review from nathanwhit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

import completions not working with import maps
2 participants
@nayeemrmn @dsherret