feat(watch): Add watch paths to test subcommand #24771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e the argument is present on command
lczerniawski
changed the title
|
@lczerniawski could you please merge |
# Conflicts: # cli/args/flags.rs
Absolutely! Just done it. |
dsherret
reviewed
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces paths’ support for test subcommands #24465.
It also adds an HMR flag for a test subcommand cause method that is used for parsing flagswatch_arg_parse_with_pathstries to read that.Let me know if that is ok, or should I split the code into two parts?
I also didn't create any PR for documentation, for me it already states that it is possible to pass paths to test watch command (even though it is not true for now)