Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(upgrade): do not error if config in cwd invalid #24689

Merged
merged 7 commits into from
Jul 23, 2024
Merged

fix(upgrade): do not error if config in cwd invalid #24689

merged 7 commits into from
Jul 23, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Jul 23, 2024 •
edited
Loading 

> deno upgrade
error: Unsupported lockfile version 'invalid'. Try upgrading Deno or recreating the lockfile.
V:\scratch
> V:\deno\target\debug\deno upgrade
Looking up latest version
Local deno version 1.45.3 is the most recent release

Closes #24517
Closes #20729

dsherret
dsherret commented Jul 23, 2024
View reviewed changes
cli/args/lockfile.rs
@@ -93,6 +98,35 @@ impl CliLockfile {
flags: &Flags,
workspace: &Workspace,
) -> Result<Option<CliLockfile>, AnyError> {
fn pkg_json_deps(maybe_pkg_json: Option<&PackageJson>) -> BTreeSet<String> {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved from cli/factory.rs

bartlomieju
bartlomieju approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit 9114a2d into denoland:main Jul 23, 2024
17 checks passed
@dsherret dsherret deleted the fix_upgrade_config_file branch July 23, 2024 23:00
dsherret added a commit that referenced this pull request Jul 26, 2024
@dsherret
fix(upgrade): do not error if config in cwd invalid (#24689)
99d8193 
```
> deno upgrade
error: Unsupported lockfile version 'invalid'. Try upgrading Deno or recreating the lockfile.
V:\scratch
> V:\deno\target\debug\deno upgrade
Looking up latest version
Local deno version 1.45.3 is the most recent release
```

Closes #24517
Closes #20729
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@nathanwhit nathanwhit Awaiting requested review from nathanwhit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deno upgrade fails in broken workspace setting in v1.45 deno upgrade fails if lockfile cannot be parsed
2 participants
@dsherret @bartlomieju