Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(publish): surface syntax errors when using --no-check #24620

Merged
merged 3 commits into from
Jul 18, 2024
Merged

fix(publish): surface syntax errors when using --no-check #24620

merged 3 commits into from
Jul 18, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Jul 17, 2024 •
edited
Loading

It was already occurring without it.

lucacasonato
lucacasonato approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dsherret dsherret merged commit ecd4f90 into denoland:main Jul 18, 2024
17 checks passed
@dsherret dsherret deleted the fix_surface_syntax_errors_no_check_publish branch July 18, 2024 03:06
@dsherret dsherret mentioned this pull request Jul 18, 2024
Open
bartlomieju pushed a commit that referenced this pull request Jul 22, 2024
@dsherret @bartlomieju
fix(publish): surface syntax errors when using --no-check (#24620)
4945714
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsherret @lucacasonato