Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/node): http request uploads of subarray of buffer should work #24603

Merged
merged 1 commit into from
Jul 16, 2024
Merged

fix(ext/node): http request uploads of subarray of buffer should work #24603

merged 1 commit into from
Jul 16, 2024

Conversation

satyarohith
Copy link
Member

Closes #24571

@satyarohith satyarohith changed the title fix(ext/node): subarray of buffer should be uploaded correctly fix(ext/node): set byteOffset, byteLength in Uint8 Jul 16, 2024
@satyarohith satyarohith changed the title fix(ext/node): set byteOffset, byteLength in Uint8 fix(ext/node): http request uploads of subarray of buffer should work Jul 16, 2024
@satyarohith satyarohith enabled auto-merge (squash) July 16, 2024 11:05
marvinhagemeister
marvinhagemeister approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@satyarohith satyarohith merged commit 6421dc3 into denoland:main Jul 16, 2024
17 checks passed
@satyarohith satyarohith deleted the fix_http_buffer_subarray branch July 16, 2024 12:37
bartlomieju pushed a commit that referenced this pull request Jul 22, 2024
@satyarohith @bartlomieju
fix(ext/node): http request uploads of subarray of buffer should work (…
1ec76fb 
…#24603)

Closes #24571
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uint8Array data corruption in node:https.request
2 participants
@satyarohith @marvinhagemeister