Reland "refactor(fetch): reimplement fetch with hyper instead of reqwest" #24593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est" This reverts commit e0cfc9d.
bartlomieju
changed the title
seanmonstar
force-pushed
the
reland_hyper_fetch
branch
from
0d4ea68
to
3dbd158
Compare
bartlomieju
added a commit
that referenced
this pull request
Jul 22, 2024
…est" (#24593) Originally landed in f6fd661. Reverted in #24574. This reland contains a fix that sends "Accept: */*" header for calls made from "FileFetcher". Absence of this header made downloading source code from JSR broken. This is tested by ensuring this header is present in the test server that servers JSR packages. --------- Co-authored-by: Sean McArthur <[email protected]>
bartlomieju
added a commit
that referenced
this pull request
Jul 24, 2024
This commit fixes handling of "authority" in the URL by properly sending "Authorization Basic..." header in `fetch` API. This is a regression from #24593 Fixes #24697 CC @seanmonstar
dsherret
pushed a commit
that referenced
this pull request
Jul 26, 2024
This commit fixes handling of "authority" in the URL by properly sending "Authorization Basic..." header in `fetch` API. This is a regression from #24593 Fixes #24697 CC @seanmonstar
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally landed in f6fd661.
Reverted in #24574.
Still need to fix the error from #24574 (comment).This reland contains a fix that sends
Accept: */*header for calls madefrom
FileFetcher. Absence of this header made downloading source codefrom JSR broken. This is tested by ensuring this header is present in the
test server that servers JSR packages.
CC @seanmonstar