Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workspace): support object config #24483

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Jul 9, 2024

This adds object config for the workspace config:

{
  "workspace": {
    "members": ["./member-1", "./member-2"]
  }
}

This is a more verbose version of "workspace": ["./member-1", "./member-2"]. Although we don't need it at the moment, it makes the naming of "workspace" more clear and leaves the object open for more config in the future.

Closes #24456

@dsherret dsherret added this to the 1.45 milestone Jul 9, 2024
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit e5c3c21 into denoland:main Jul 9, 2024
17 checks passed
@dsherret dsherret deleted the feat_workspace_config_object branch July 9, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaking change in unstable workspaces configuration field
2 participants