fix: do not download compilerOptions -> types when not type checking #24473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Jul 8, 2024
| @@ -481,7 +481,11 @@ impl ModuleGraphBuilder { | |||
| } | |||
| } | |||
|
|
|||
| let maybe_imports = self.options.to_maybe_imports()?; | |||
| let maybe_imports = if options.graph_kind.include_types() { | |||
| self.options.to_compiler_option_types()? | |||
There was a problem hiding this comment.
The error for these failing only gets surfaced when type checking.
dsherret
commented
Jul 8, 2024
| /// Return any imports that should be brought into the scope of the module | ||
| /// graph. | ||
| pub fn to_maybe_imports( | ||
| pub fn to_compiler_option_types( | ||
| &self, | ||
| ) -> Result<Vec<deno_graph::ReferrerImports>, AnyError> { | ||
| self.workspace.to_maybe_imports().map(|maybe_imports| { |
There was a problem hiding this comment.
Have a separate PR that I'll land over time to rename this here: denoland/deno_config#75
bartlomieju
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22738