Handle compiler diagnostics in Rust. #2445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
kitsonk
force-pushed
the
rust-diagnostics
branch
2 times, most recently
from
bd5acec to
b59d403
Compare
ry
reviewed
Jun 3, 2019
ry
reviewed
Jun 3, 2019
ry
reviewed
Jun 3, 2019
ry
reviewed
Jun 3, 2019
ry
reviewed
Jun 3, 2019
|
@ry I think all the feedback has been addressed. |
|
Actually I need to upgrade prettier it looks like. It needs to be running on 3.4 TypeScript, because I had to use some new 3.4 syntax to get some of the code to work, and prettier doesn't like it. |
|
Ok, finally, should be all fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1738
Replaces #2310
This PR is a more simplified approach to dealing with diagnostics. It only touches the cli in Rust.
It doesn't touch any of the
JSErrorcode, which means it doesn't align it to the TypeScript style of output. There is a trait though incli/diagnostic.tscalledDisplayFormatterwhich could be moved into core and simplify the logic of formatting the parts of aJSErrorto align the TypeScript style, which could be tackled as a seperate PR.